fix(Glyph3DMapper): shift+scale for large coords #3304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floryst
requested review from
sankhesh and
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR fixes jittering issues in the Glyph3DMapper when rendering objects with large coordinates by implementing a shift+scale transformation approach.
- Adds coordinate shift and scale computation to handle large coordinate values
- Applies transformations to both matrix buffers and primitive coordinate buffers
- Ensures the Glyph3DMapper's shift+scale takes precedence over the base mapper's transformation
floryst
force-pushed
the
glyphmapper-shift-scale
branch
from
378955e to
e11d41b
Compare
finetjul
approved these changes
Jul 31, 2025
|
@floryst some tests are failing 'Test Suite: Test getPixelWorldHeightAtCoord'
2025-07-31T17:47:44.3348969Z Chrome 138.0.0.0 (Linux x86_64) INFO: ' [PASS] Image match resolution'
2025-07-31T17:47:44.3350652Z Chrome 138.0.0.0 (Linux x86_64) INFO: ' [FAIL] [Widgets/Core/WidgetManager/test/testNoScaleInPixelsWithPerspective] Matching image - delta 97.56% (count: 87808)'
2025-07-31T17:47:44.3753081Z Chrome 138.0.0.0 (Linux x86_64) INFO: ' [PASS] Image match resolution'
2025-07-31T17:47:44.3761310Z Chrome 138.0.0.0 (Linux x86_64) INFO: ' [FAIL] [Widgets/Core/WidgetManager/test/testNoScaleInPixelsWithParallel] Matching image - delta 88.08% (count: 79271)'
2025-07-31T17:47:44.4061230Z Chrome 138.0.0.0 (Linux x86_64) INFO: ' [PASS] Image match resolution'
2025-07-31T17:47:44.4069023Z Chrome 138.0.0.0 (Linux x86_64) INFO: ' [FAIL] [Widgets/Core/WidgetManager/test/testScaleInPixelsWithPerspective] Matching image - delta 95.34% (count: 85807)'
2025-07-31T17:47:44.4265524Z Chrome 138.0.0.0 (Linux x86_64) INFO: ' [PASS] Image match resolution'
2025-07-31T17:47:44.4273077Z Chrome 138.0.0.0 (Linux x86_64) INFO: ' [FAIL] [Widgets/Core/WidgetManager/test/scaleInPixelsWithParallel] Matching image - delta 64.24% (count: 57813)' |
|
Yeah I'm looking into why the tests are failing. |
floryst
force-pushed
the
glyphmapper-shift-scale
branch
from
e11d41b to
2bf3702
Compare
|
Tests have passed. This is good for review @sankhesh |
|
🎉 This PR is included in version 34.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The glyphmapper does not handle large coordinates, resulting in jittering
Results
Large coordinates no longer jitter when using the glyph3dmapper
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting